Fix warnings for rust 1.88 and upgrade CI rust version#3632
Merged
stevenengler merged 7 commits intoshadow:mainfrom Jul 23, 2025
Merged
Fix warnings for rust 1.88 and upgrade CI rust version#3632stevenengler merged 7 commits intoshadow:mainfrom
stevenengler merged 7 commits intoshadow:mainfrom
Conversation
robgjansen
approved these changes
Jul 21, 2025
Member
robgjansen
left a comment
There was a problem hiding this comment.
LGTM!
I'm not sure about 1f98f17, so if you want feedback about that specific change you might want to ask @sporksmith.
These were done by `clippy --fix` and hand-edited where needed.
```text
error[E0283]: type annotations needed
--> test/unistd/test_unistd.rs:133:59
|
133 | assert_eq!(expected_name.sysname, to_cstr(&n.sysname).into());
| ^^^^
|
= note: cannot satisfy `_: From<&CStr>`
= note: required for `&CStr` to implement `Into<_>`
help: try using a fully qualified path to specify the expected types
|
133 - assert_eq!(expected_name.sysname, to_cstr(&n.sysname).into());
133 + assert_eq!(expected_name.sysname, <&CStr as Into<T>>::into(to_cstr(&n.sysname)));
|
For more information about this error, try `rustc --explain E0283`.
```
Contributor
Author
I removed that commit from this MR and replaced it with a new commit that does just an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes clippy warnings and errors in rust 1.88, and upgrades the rust version in CI.