Fix builds that don't use cmake (for example clippy)#3631
Merged
stevenengler merged 4 commits intoshadow:mainfrom Jul 22, 2025
Merged
Fix builds that don't use cmake (for example clippy)#3631stevenengler merged 4 commits intoshadow:mainfrom
stevenengler merged 4 commits intoshadow:mainfrom
Conversation
This means that other tools like clippy which run the build scripts will use the same standard library as the main cmake build.
38b2bd5 to
ac5e4e2
Compare
4292b71 to
ac5e4e2
Compare
robgjansen
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy fails to run on newer distros since the build scripts compile C code using a different
-stdoption when building with cmake vs cargo directly. My guess is that the distro defaults to a newer C compiler std than gnu11.This PR fixes the bug in the C code, and moves the
-std=option from cmake to the rust build scripts so that we don't run into the situation where the normal build and clippy build use different C standards.