Skip to content

Update 'setup' script to pass "OFF" to cmake#3592

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:setup-flags
May 19, 2025
Merged

Update 'setup' script to pass "OFF" to cmake#3592
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:setup-flags

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented May 17, 2025 •
edited
Loading

Closes #3586.

$ ./setup build
[...]
-- SHADOW_TEST=OFF
-- SHADOW_WERROR=OFF
-- SHADOW_EXTRA_TESTS=OFF
-- SHADOW_USE_PERF_TIMERS=OFF
$ ./setup build --test --werror
[...]
-- SHADOW_TEST=ON
-- SHADOW_WERROR=ON
-- SHADOW_EXTRA_TESTS=OFF
-- SHADOW_USE_PERF_TIMERS=OFF
$ ./setup build
[...]
-- SHADOW_TEST=OFF
-- SHADOW_WERROR=OFF
-- SHADOW_EXTRA_TESTS=OFF
-- SHADOW_USE_PERF_TIMERS=OFF

@stevenengler stevenengler self-assigned this May 17, 2025
@github-actions github-actions bot added Component: Testing Unit and integration tests and frameworks Component: Documentation In-repository documentation, under docs/ labels May 17, 2025
@stevenengler stevenengler requested a review from a team May 19, 2025 02:11
@stevenengler stevenengler enabled auto-merge May 19, 2025 04:15
@stevenengler stevenengler merged commit 9bf10d4 into shadow:main May 19, 2025
25 checks passed
@stevenengler stevenengler deleted the setup-flags branch May 19, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

No way to disable cmake options after they've been cached

2 participants

@stevenengler @sporksmith