Add another regression test for issue 3100#3570
Merged
stevenengler merged 5 commits intoshadow:mainfrom Apr 24, 2025
Merged
Conversation
This tests that the FIN is correctly sent when the socket is `close()`d immediately after sending bytes.
sporksmith
approved these changes
Apr 24, 2025
Contributor
Author
|
Added changes to set I think these changes should be uncontroversial, but I'll wait a little before merging just in case. |
We don't enable pcaps in the 3100-a test, so for consistency we'll disable it for the 3100-b test.
Contributor
Author
|
Noticed a typo in a comment, so did a fixup/rebase to fix it. |
sporksmith
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3100. This is the second example simulation in that issue.