Skip to content

Use atomic refcount in packet#3493

Closed
stevenengler wants to merge 1 commit intoshadow:mainfrom
stevenengler:packet-atomics
Closed

Use atomic refcount in packet#3493
stevenengler wants to merge 1 commit intoshadow:mainfrom
stevenengler:packet-atomics

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jan 14, 2025

Switches the C packet refcounts to atomics. The memory orderings try to approximately match the memory orderings used in Arc::clone and Arc::drop.

Using for a benchmark.

@stevenengler stevenengler self-assigned this Jan 14, 2025
@github-actions github-actions bot added Component: Testing Unit and integration tests and frameworks Component: Main Composing the core Shadow executable labels Jan 14, 2025
@robgjansen
Copy link
Copy Markdown
Member

Thank so much for this Steve! I'm closing now that we found the performance problem in #3492 and #3492 is merged now.

@robgjansen robgjansen closed this Feb 17, 2025
@stevenengler stevenengler deleted the packet-atomics branch February 18, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants