Merged
Conversation
d640cd9 to
2f50d79
Compare
robgjansen
approved these changes
Dec 24, 2024
We don't yet support broadcast sockets, so we return 0 for getsockopt and don't warn if given 0 for setsockopt.
2f50d79 to
594f903
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we had stubs for setsockopt with
SO_BROADCASTfor tcp and udp:The old behaviour for tcp/udp was:
The new behaviour for tcp/udp is:
Our tests aren't set up to test get/setsockopt for unix sockets, so I didn't implement the option for unix sockets. I would expect it to return an error.
Closes #3439.