DNS: Allow assignment of restricted IPs#3414
Merged
sporksmith merged 3 commits intoshadow:mainfrom Sep 19, 2024
Merged
Conversation
2fdf7e9 to
77d9f79
Compare
robgjansen
approved these changes
Sep 19, 2024
Member
robgjansen
left a comment
There was a problem hiding this comment.
I'm not seeing any harm in being more flexible in IP address assignment, as long as all addresses are routable in the network graph.
There are some changes needed, but I don't need to review them afterwords.
The comment that was here indicated intent to allow restricted IP addresses as long as they were unique (or local), but the code rejected them. I *think* we want to reject any non-unique + non-local IP address assignment, and don't otherwise care if it's in a restricted range.
77d9f79 to
d070c84
Compare
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment that was here indicated intent to allow restricted IP addresses as long as they were unique (or local), but the code rejected them.
I think we want to reject any non-unique + non-local IP address assignment, and don't otherwise care if it's in a restricted range.