Drop packet instead of panicking if dst IP is unknown#3411
Merged
stevenengler merged 1 commit intoshadow:mainfrom Sep 12, 2024
Merged
Drop packet instead of panicking if dst IP is unknown#3411stevenengler merged 1 commit intoshadow:mainfrom
stevenengler merged 1 commit intoshadow:mainfrom
Conversation
sporksmith
approved these changes
Sep 12, 2024
Contributor
sporksmith
left a comment
There was a problem hiding this comment.
Nice use of python for a succinct regression test :)
Also added a regression test.
3c1e2a5 to
4d27f81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3148. Also added a regression test.
This was really easy to add now that we have
log_once_per_value_at_level!().