Fix warnings in rust 1.82-beta#3406
Merged
stevenengler merged 3 commits intoshadow:mainfrom Sep 9, 2024
Merged
Conversation
sporksmith
approved these changes
Sep 9, 2024
This is needed in rustc 1.82.0-beta.2.
This is needed in rustc 1.82.0-beta.2.
I can understand why this is useful for libraries published to crates.io, but it's mostly just unnecessary work for Shadow. But it's easier to just follow clippy than to fight it, so here we are... This is needed in rustc 1.82.0-beta.2.
e3be5a5 to
9e36c4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might as well fix these now while I'm looking at them.