Add the fchmodat2 syscall handler and fix fchmodat#3384
Merged
stevenengler merged 2 commits intoshadow:mainfrom Aug 10, 2024
Merged
Add the fchmodat2 syscall handler and fix fchmodat#3384stevenengler merged 2 commits intoshadow:mainfrom
stevenengler merged 2 commits intoshadow:mainfrom
Conversation
sporksmith
approved these changes
Aug 5, 2024
The `fchmodat` syscall doesn't actually take a flags argument, so this value is undefined.
2dd8402 to
9b2f72a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'fchmodat' syscall doesn't have a flags argument, and there was recently a 'fchmodat2' syscall that does.
The PR only needs a review for the last two commits. the others are from other dependent open PRs.