Add exception for loom cfg in rust 1.80-beta#3354
Merged
stevenengler merged 1 commit intoshadow:mainfrom Jun 12, 2024
Merged
Conversation
This is in preparation for the upcoming changes in rust 1.80: https://blog.rust-lang.org/2024/05/06/check-cfg.html Fixes around 40 warnings of the form: ``` warning: unexpected `cfg` condition name: `loom` --> lib/vasi-sync/src/sync.rs:163:15 | 163 | #[cfg(not(loom))] | ^^^^ | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(loom)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(loom)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration ``` On old (including the current) rust versions, this commit causes: ``` warning: lib/vasi-sync/Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg ```
11020a8 to
b47cf34
Compare
sporksmith
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for the upcoming changes in rust 1.80:
https://blog.rust-lang.org/2024/05/06/check-cfg.html
Rust 1.80 will likely be released before we publish another Shadow release (end of July), so I don't think it hurts to merge now.
Fixes around 40 warnings of the form:
On old (including the current) rust versions, this commit causes: