Skip to content

Add OnceSet for unhandled syscall warnings#3349

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:once-set
Jun 8, 2024
Merged

Add OnceSet for unhandled syscall warnings#3349
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:once-set

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

This pulls the OnceSet commit out of #3332. It moves the locking correctness logic to its own type. This also adds changes for the following review comments from #3332:

@stevenengler stevenengler self-assigned this Jun 8, 2024
@github-actions github-actions bot added Component: Main Composing the core Shadow executable labels Jun 8, 2024
@stevenengler stevenengler requested a review from sporksmith June 8, 2024 21:53
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! With this modularized maybe we can apply this to other unhandled parameters such as socket options...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants