Fix error-handling for posix_spawn#3344
Merged
sporksmith merged 3 commits intoshadow:mainfrom Jun 6, 2024
Merged
Conversation
c0a3c8e to
649a4ac
Compare
On failure, `posix_spawn` and related functions return the error code directly instead of through errno. This fixes our handling of the return codes to correctly detect and interpret errors from these functions.
We were incorrectly passing a format string to `Result::expect`, which just outputs the string without formatting. We can use `unwrap_or_else` instead to do formatting, and avoid doing the formatting in the non-error case.
649a4ac to
2381838
Compare
stevenengler
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On failure,
posix_spawnand related functions return the error codedirectly instead of through errno. This fixes our handling of the return
codes to correctly detect and interpret errors from these functions.