Move the kill syscall handler to rust#3314
Merged
stevenengler merged 1 commit intoshadow:mainfrom Mar 22, 2024
Merged
Conversation
2d6b1d0 to
fa99580
Compare
robgjansen
approved these changes
Mar 22, 2024
Member
robgjansen
left a comment
There was a problem hiding this comment.
Always happy to see a net reduction in code :)
sporksmith
reviewed
Mar 22, 2024
61e677c to
fa99580
Compare
stevenengler
commented
Mar 22, 2024
fa99580 to
61e677c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed two
ENOSYSreturn values toENOTSUP. I've found it to be confusing when a shadow syscall handler returnsENOSYS, so I thinkENOTSUPis more clear.