Ensure clone handler drops RootedRc's on early exit#3291
Merged
sporksmith merged 5 commits intoshadow:mainfrom Feb 1, 2024
Merged
Ensure clone handler drops RootedRc's on early exit#3291sporksmith merged 5 commits intoshadow:mainfrom
sporksmith merged 5 commits intoshadow:mainfrom
Conversation
This is a regression test for shadow#3290
This will make it easier to deal with RootedRc locals + early returns.
05999ba to
1bb680b
Compare
robgjansen
approved these changes
Feb 1, 2024
Member
robgjansen
left a comment
There was a problem hiding this comment.
Looks great, and much more failsafe :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3290