Skip to content

Fix --version#3287

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:fix-version
Jan 22, 2024
Merged

Fix --version#3287
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:fix-version

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jan 22, 2024 •
edited
Loading

The --show-build-info shows the correct version information, but the --version flag doesn't:

$ shadow --show-build-info
Shadow 3.1.0 — v3.1.0-67-g73bdff28c-dirty 2024-01-17--10:02:04
GLib 2.64.6
...
$ shadow --version
Shadow

This PR fixes the --version:

$ shadow --version
Shadow 3.1.0 — v3.1.0-67-g73bdff28c-dirty 2024-01-17--10:02:04

I'm not sure how common it is to put other stuff like v3.1.0-67-g73bdff28c-dirty 2024-01-17--10:02:04 into the --version output, but probably doesn't hurt unless anyone wants to parse the --version output.

@stevenengler stevenengler self-assigned this Jan 22, 2024
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 22, 2024
@stevenengler stevenengler merged commit 56d9633 into shadow:main Jan 22, 2024
@stevenengler stevenengler deleted the fix-version branch January 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robgjansen robgjansen robgjansen approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @robgjansen