Skip to content

Fix signal handler initialization in forked child processes#3284

Merged
sporksmith merged 4 commits intoshadow:mainfrom
sporksmith:clone-clear-sighand
Jan 17, 2024
Merged

Fix signal handler initialization in forked child processes#3284
sporksmith merged 4 commits intoshadow:mainfrom
sporksmith:clone-clear-sighand

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Jan 16, 2024

No description provided.

@sporksmith sporksmith self-assigned this Jan 16, 2024
@github-actions github-actions bot added Component: Libraries Support functions like LD_PRELOAD and logging Component: Testing Unit and integration tests and frameworks Component: Main Composing the core Shadow executable Component: Documentation In-repository documentation, under docs/ labels Jan 16, 2024
@sporksmith sporksmith changed the title Clone clear sighand Fix signal handler initialization in forked child processes Jan 16, 2024
@sporksmith
linux-api: add wrapper for clone3 syscall
55cb60b
@sporksmith
linux-api: Add methods for building clone_args
8f8b85e
@sporksmith
test_fork: add test for CLONE_CLEAR_SIGHAND
9497f7a 
This is currently enabled for linux-only, since it's not yet implemented
in shadow.
@sporksmith
clone3: support CLONE_CLEAR_SIGHAND and don't clear if not set
ca84567 
Previously fork-like invocations of clone incorrectly reset signal
handlers, as if `CLONE_CLEAR_SIGHAND` was used.

The default is now fixed to copy signal handlers from the parent
process, and we add support for the `CLONE_CLEAR_SIGHAND` flag to clear
them.
@sporksmith sporksmith marked this pull request as ready for review January 17, 2024 00:09
@sporksmith sporksmith requested a review from robgjansen January 17, 2024 00:09
@sporksmith
Copy link
Copy Markdown
Contributor Author

sporksmith commented Jan 17, 2024

Verified this fixes the fork-linux test on fedora:39 (though there are still other tests failing)

$ ci/run.sh -i -c fedora:39 -C gcc -b debug
...
The following tests FAILED:
	 61 - simple_http-shadow (Failed)
	 62 - gc-linux (Failed)
	 63 - gc-shadow (Failed)
	 65 - goroutines-linux (Failed)
	 66 - goroutines-shadow (Failed)

@sporksmith sporksmith linked an issue Jan 17, 2024 that may be closed by this pull request
posix_spawn fails starting in glibc-2.38 #3266
Closed
@robgjansen
Copy link
Copy Markdown
Member

robgjansen commented Jan 17, 2024

I believe those other failures are #3267

robgjansen
robgjansen approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sporksmith sporksmith merged commit 73bdff2 into shadow:main Jan 17, 2024
@sporksmith sporksmith deleted the clone-clear-sighand branch January 17, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robgjansen robgjansen robgjansen approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Documentation In-repository documentation, under docs/ Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Support subprocess creation and manag...

Development

Successfully merging this pull request may close these issues.

posix_spawn fails starting in glibc-2.38

2 participants

@sporksmith @robgjansen