Support listening for SharedBuf signal events#3276
Closed
stevenengler wants to merge 1 commit intoshadow:mainfrom
Closed
Support listening for SharedBuf signal events#3276stevenengler wants to merge 1 commit intoshadow:mainfrom
SharedBuf signal events#3276stevenengler wants to merge 1 commit intoshadow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3250, support for listening for file signal events was added. This was meant for edge-triggered epoll, where shadow could emit a signal when a file's buffer changed even if the file's state didn't change. This adds supports for signals to the
SharedBuftype, which is a shared buffer used by pipes and unix sockets.This is a little awkward to fit in to the existing pipe and unix socket code, but I think it's good enough for now.
Edit: Not planning on merging this since #3243 will contain a similar version, but leaving this PR open so that after #3243 is merged I can see if there's anything in here I still want to keep.