Fix return value for connect() with unix and tcp sockets#3191
Merged
stevenengler merged 1 commit intoshadow:mainfrom Sep 28, 2023
Merged
Fix return value for connect() with unix and tcp sockets#3191stevenengler merged 1 commit intoshadow:mainfrom
stevenengler merged 1 commit intoshadow:mainfrom
Conversation
sporksmith
approved these changes
Sep 28, 2023
These sockets were returning the wrong value when connect() was called on a listening socket. The C TCP sockets were panicking due to a failed assert.
515c325 to
7039562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These sockets were returning the wrong value when connect() was called on a listening socket. The C TCP sockets were panicking due to a failed assert.