Merged
Conversation
e32261b to
e48e11a
Compare
Contributor
Author
|
It occurred to me how to test whether pending signals are cleared during exec, so I did. Turns out they're not. Will add a fixup commit on Monday. Here's the test program: If pending signals were cleared, this should loop forever re-execing itself. But it appears they're not, so it doesn't. Output: |
stevenengler
approved these changes
Sep 25, 2023
Previously when we forked a process, we'd dup the descriptors kept in the shadow `Process` object into the new `Process`, and put the new descriptor numbers in shared memory for the shim-side code of the new managed process to use. This is incorrect, though, since the dup'd descriptor doesn't exist in the new native process. The original descriptors are transferred between shadow and the managed process when it's first spawn, using `posix_spawn` actions. It's simplest to just use those in the new process as well, since the forked process will also inherit them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2988 (split
execveatinto #3166)