MemoryCopier: use live thread ID for writes#2913
Merged
sporksmith merged 3 commits intoshadow:mainfrom May 9, 2023
Merged
Conversation
stevenengler
approved these changes
May 9, 2023
In particular this fixes a crash when reaping a thread and trying to write to the `child_tid` address, since the current thread is no longer live and can't be used with the `process_vm_writev` syscall. This problem was mostly latent, since when the memory mapper is enabled, we usually do the write through shared memory instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular this fixes a crash when reaping a thread and trying to
write to the
child_tidaddress, since the current thread is no longerlive and can't be used with the
process_vm_writevsyscall.This problem was mostly latent, since when the memory mapper is enabled,
we usually do the write through shared memory instead.