Drop per-process exitcode files#2906
Merged
sporksmith merged 2 commits intoshadow:mainfrom May 4, 2023
Merged
Conversation
The semantics of these were a bit awkward (e.g. 128+signum for
death-by-signal; empty for still-running), and the per-process
`expected_final_state` attribute replaces their primary use-case.
If we decide to bring these back, we should consider a richer format;
maybe just the serialized actual process final state. e.g. "running",
"{exited: 0}", "{signaled: SIGINT}", ...
We no longer create any new files after Process creation.
stevenengler
approved these changes
May 4, 2023
Contributor
stevenengler
left a comment
There was a problem hiding this comment.
I thought we had tests that checked that processes exited correctly by reading the exitcode file, but I guess not.
Contributor
Author
I replaced those with using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semantics of these were a bit awkward (e.g. 128+signum for death-by-signal; empty for still-running), and the per-process
expected_final_stateattribute replaces their primary use-case.If we decide to bring these back, we should consider a richer format; maybe just the serialized actual process final state. e.g. "running", "{exited: 0}", "{signaled: SIGINT}", ...