Add config option expected_end_state #2886
Merged
sporksmith merged 8 commits intoshadow:mainfrom May 3, 2023
Merged
Conversation
6140242 to
b7fff9d
Compare
b7fff9d to
1ce90fa
Compare
1ce90fa to
fd5cdcb
Compare
fd5cdcb to
ac055b6
Compare
stevenengler
approved these changes
Apr 26, 2023
...onfig/expected_final_process_state/expected_final_process_state_expect_exit_get_running.yaml
Outdated
Show resolved
Hide resolved
d8fcbb7 to
af28171
Compare
Contributor
Author
|
Changed to use the untagged enum trick to avoid requiring the |
stevenengler
approved these changes
May 2, 2023
In particular this ensures we don't circumvent the error checking of the final process exit status when transitioning from Running to Zombie.
This allows the user to specify the expected state of a process at the end of a simulation. This also changes the default behavior to treat a process still running at the end of the simulation as an error. See shadow#2034
Explicit yaml types can be difficult to work with. e.g. it's unclear how
to get pyyaml to emit `!running` (and not `"running"` or `!running {}`.
Even if we solved it for pyyaml, users are likely to run into problems
with other tools.
With a few tweaks we get a more intuitive yaml representation, at the
expense of a slightly more complex internal representation.
af28171 to
cdf0836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2034