Futex should operate on the &AtomicI32, not the &Arc#2866
Merged
stevenengler merged 1 commit intoshadow:mainfrom Apr 12, 2023
Merged
Futex should operate on the &AtomicI32, not the &Arc#2866stevenengler merged 1 commit intoshadow:mainfrom
&AtomicI32, not the &Arc#2866stevenengler merged 1 commit intoshadow:mainfrom
Conversation
This bug caused the waiter to spin rather than futex-wait.
sporksmith
approved these changes
Apr 12, 2023
Contributor
Author
|
The nightly benchmark after fixing this bug:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest nightly tor benchmark showed a huge runtime performance change:
@sporksmith found that we were performing futex operations on the
Arcaddress rather than its innerAtomicI32address, causing the waiter to spin. This was caused by a bug in #2846.We expect that this PR will increase the runtime back to the original runtime, and we can investigate spinning properly later.