CI: don't run on multiple base images#2832
Merged
sporksmith merged 8 commits intoshadow:mainfrom Apr 4, 2023
Merged
Conversation
This is one of the planned breaking changes for Shadow 3.0. shadow#2496
This is similar to the existing `read` method, and I think it is a little nicer to use than `copy_to_ptr` in simpler cases.
Contributor
Author
|
@robgjansen will need to change the required checks before it can be merged. No rush on this one; we could wait to discuss it in the group meeting. |
stevenengler
approved these changes
Apr 4, 2023
Member
|
Done. Please double check that the correct tests are set as required and let me know if we need any more tweaks. |
It turns out that the GitHub Action Ubuntu images both use the same kernel version, so we probably don't get much value out of running on multiple base images. Both non-deprecated images currently use kernel 5.15.0-1034-azure. https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
Some of these were intentionally running on the oldest available base image to try to test on an older kernel. Since it turns out GitHub's Ubuntu base images use the same kernel version, we might as well run on the newest one. Similarly, since all of these tests run in containers, it's probably not worth pinning the base image to a specific version of Ubuntu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the GitHub Action Ubuntu images both use the same
kernel version, so we probably don't get much value out of running on
multiple base images.
Both non-deprecated images currently use kernel 5.15.0-1034-azure.
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2004-Readme.md
https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md
Since our tests all run in containers, it's probably not worth pinning the base image to a specific image of Ubuntu at all, so this also changes the base images to "ubuntu-latest", which is currently 22.04.