Add a generic type to ForeignPtr#2827
Merged
stevenengler merged 19 commits intoshadow:mainfrom Apr 3, 2023
Merged
Conversation
sporksmith
reviewed
Apr 3, 2023
`UntypedForeignPtr` should only be used in C code and maps to `ForeignPtr<()>` in rust. This commit changes all existing rust uses of `ForeignPtr` to `ForeignPtr<()>`, allowing us to start changing the generic type in the future.
Used the following command: ``` rg 'TypedArrayForeignPtr' --files-with-matches | xargs sed -i 's/TypedArrayForeignPtr/ForeignArrayPtr/g' ```
Realized a better way of preventing type inference without requiring a second generic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2813.
This makes
ForeignPtrtyped. There aren't many places where we need untyped pointers in Shadow, so making pointers typed should be the default. This also means that for a lot of pointers, we can define their type directly in the syscall handler. Pointer types should now be self-documenting, and it should be harder to accidentally access the pointers as the wrong type. AnUntypedForeignPtrwas added for compatibility with the C code.ForeignPtrUntypedForeignPtrfor C code which maps toForeignPtr<()>in rust codeTypedArrayForeignPtrtoForeignArrayPtrThe intermediate commits have a lot of casts between pointer types so that each commit would build and run, but the final code should have only a few pointer type conversions.
There are still some things that can be cleaned up, but I think this gets most of the code in.