Skip to content

Do not implicitly search current directory for executables#2824

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:no-cwd
Apr 3, 2023
Merged

Do not implicitly search current directory for executables#2824
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:no-cwd

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

This is a planned breaking change for the Shadow 3.0 release. See #2496 and #2447 (comment).

This forces users to explicitly use "./" to specify a binary in the current directory.

@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks labels Mar 31, 2023
@sporksmith sporksmith requested a review from stevenengler March 31, 2023 20:30
@sporksmith
Copy link
Copy Markdown
Contributor Author

Not quite ready yet after all; forgot to run the --extra tests locally

@sporksmith sporksmith removed the request for review from stevenengler March 31, 2023 21:17
@github-actions github-actions bot added Component: Build Build/install tools and dependencies Component: Tools Peripheral tools like parsing log files or visualizing results labels Mar 31, 2023
@sporksmith sporksmith requested a review from stevenengler March 31, 2023 21:59
@sporksmith
Copy link
Copy Markdown
Contributor Author

Tests passing now, with #2825 cherry-picked in. I'll plan to merge #2825 first and then drop that commit from this PR.

@github-actions github-actions bot removed Component: Tools Peripheral tools like parsing log files or visualizing results Component: Build Build/install tools and dependencies labels Apr 3, 2023
This is a planned breaking change for the Shadow 3.0 release.
See shadow#2496 and
shadow#2447 (comment).

This forces users to explicitly use "./" to specify a binary in the
current directory.
@sporksmith sporksmith enabled auto-merge (squash) April 3, 2023 15:33
@sporksmith sporksmith merged commit 5efe48f into shadow:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants