Add context to strace output when we can't read memory#2821
Merged
robgjansen merged 2 commits intoshadow:mainfrom Jan 3, 2024
Merged
Add context to strace output when we can't read memory#2821robgjansen merged 2 commits intoshadow:mainfrom
robgjansen merged 2 commits intoshadow:mainfrom
Conversation
7de8f87 to
5eeb377
Compare
sporksmith
approved these changes
Mar 30, 2023
Contributor
sporksmith
left a comment
There was a problem hiding this comment.
re the downsides you mentioned, we could special-case 0 to print "NULL" instead of "invalid", and/or use something like "unreadable" instead of "invalid"
I'm also fine with merging this as-is, though.
Member
|
After discussion, Rob will take over this PR. Here are the cases:
Rob will come up with tag names for these cases. |
5eeb377 to
00a3ef1
Compare
Member
|
@stevenengler I don't know if we still want this, or maybe I chose bad pointer suffix names, but here is my try at progressing this PR. I'm OK if we decide that it's not enough of an improvement and just want to close it instead. |
robgjansen
reviewed
Jan 2, 2024
stevenengler
commented
Jan 3, 2024
Contributor
Author
stevenengler
left a comment
There was a problem hiding this comment.
Changes look good to me.
3fc28af to
7171a18
Compare
<invalid> in strace output when we can't read memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #2815 (comment).
If the strace logger is unable to read some memory, a
<invalid>tag will be added after the pointer. This matches when an invalid flag is passed to a syscall.There are two downsides to this change.
recvfrom.