Add syscall handlers for sendmsg() and recvmsg()#2811
Merged
stevenengler merged 7 commits intoshadow:mainfrom Mar 29, 2023
Merged
Add syscall handlers for sendmsg() and recvmsg()#2811stevenengler merged 7 commits intoshadow:mainfrom
sendmsg() and recvmsg()#2811stevenengler merged 7 commits intoshadow:mainfrom
Conversation
929f475 to
5bb69dd
Compare
sporksmith
approved these changes
Mar 29, 2023
5bb69dd to
b88696b
Compare
This adds tests for the simplest cases of `sendmsg()` and `recvmsg()` (a single iovec, no control data, etc).
None of the existing tests made sure that the sockets actually block when they're supposed to.
b88696b to
ad72cac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each sendto/recvfrom test, we also now test sendmsg/recvmsg, but this only tests the simple cases of sendmsg and recvmsg (for example, no control data, a single iovec, doesn't return the message flags, etc). In the future we should add more complex tests, but these tests do make sure we're handling the simple cases correctly (for example correctly returning the socket address, blocking behaviour, etc).