Skip to content

Cleanup syscall_types import redirection#2807

Merged
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:syscall-types-imports
Mar 27, 2023
Merged

Cleanup syscall_types import redirection#2807
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:syscall-types-imports

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Mar 27, 2023

Cleanup a dangling "XXX temp" TODO after moving some syscall_types to from the main crate to the shadow_shim_helper_rs crate to change all use statements to use the new location directly instead of using a pub use in the old location.

Also do a one-time global automated cleanup of rust import grouping.

Cleanup a dangling TODO after moving some syscall_types to from the
`main` crate to the `shadow_shim_helper_rs` crate to change all `use`
statements to use the new location directly instead of using a `pub use`
in the old location.
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Mar 27, 2023
In previous discussion we agreed in theory on rustfmt's
`StdExternalCrate` grouping policy. Unfortunately we currently can't
use this in our default config, since it only works on nightly.

This is a one-time run of rustfmt using that policy with the nightly
compiler.

It cleans up the ordering both from the previous commit (which was
semi-automated using sed) and everywhere else.
@github-actions github-actions bot added Component: Libraries Support functions like LD_PRELOAD and logging Component: Testing Unit and integration tests and frameworks labels Mar 27, 2023
@sporksmith sporksmith requested a review from stevenengler March 27, 2023 17:24
@sporksmith sporksmith merged commit 18040ae into shadow:main Mar 27, 2023
@sporksmith sporksmith deleted the syscall-types-imports branch March 27, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants