Unregister threads with ChildPidWatcher#2806
Merged
sporksmith merged 2 commits intoshadow:mainfrom Mar 27, 2023
Merged
Conversation
We were failing to save the ChildPidWatcher notification handles, which in turn meant we weren't unregistering threads with the ChildPidWatcher after they exited, thus creating a resource leak. The relevant data was still getting freed when the whole Process exited, so it would have only affected Processes that had many threads start and end over their lifetime. The callback registered for each thread is only about 16 bytes - a function pointer and a data pointer.
…ered The watcher may have already unregistered the pid if it already detected its exit and executed the callbacks.
Contributor
Author
|
The ChildPidWatcher could use some more cleanup, but just doing the minimal fix for now to fix the resource leak. |
stevenengler
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were failing to save the ChildPidWatcher notification handles, which
in turn meant we weren't unregistering threads with the ChildPidWatcher
after they exited, thus creating a resource leak. The relevant data was
still getting freed when the whole Process exited, so it would have only
affected Processes that had many threads start and end over their
lifetime.
The callback registered for each thread is only about 16 bytes - a
function pointer and a data pointer.
Additionally this fixes a bug causing a panic when we do unregister a callback for a process that's already been unregistered.