Fix preadv/preadv2/etc offset calculation and handling#2802
Merged
stevenengler merged 3 commits intoshadow:mainfrom Mar 23, 2023
Merged
Fix preadv/preadv2/etc offset calculation and handling#2802stevenengler merged 3 commits intoshadow:mainfrom
stevenengler merged 3 commits intoshadow:mainfrom
Conversation
79a1349 to
498750d
Compare
The previous version didn't calculate the correct offset for negative or large offsets.
498750d to
abb001c
Compare
abb001c to
fba4aa2
Compare
sporksmith
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow didn't reconstruct the offset correctly and didn't handle negative offsets.