Closed
Conversation
This changes the names to match what cbindgen wants to call these when we migrate this enum to Rust. (I tried instead adding cbindgen annotations to a Rust version of the enum, but it doesn't seem to work).
Notably this removes the user-facing experimental options `preload_spin_max` and `use_explicit_block_message`, and hard-wires the current defaults of not spinning and not using an explicit block message (which would be redundant with spinning disabled). We've stopped using these options, and I haven't bothered reimplementing them in the Rust version of `IPCData`.
We can use ShimEvent's discriminant directly instead of maintaining a mapping.
15ed2f4 to
70ed32f
Compare
Contributor
Author
|
This gets back a little bit of performance, but still a little worse than nightly:
|
Merged
Contributor
Author
|
I think the improvement here is an illusion. It doesn't show up in microbenchmarks, and the current version of IPC using SelfContainedMutex now appears to have the same performance as the C version. https://github.com/shadow/benchmark-results/blob/master/tor/2023-03-16-T13-26-54/plots/run_time.png |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2775 that removes the "reading" and "writing" states of
SelfContainedChannel. Hopefully that will improve performance. The downside is thatsendandreceivebecomeunsafe, since we will have undefined behavior in the case of parallel calls tosendor toreceive.