Merged
Conversation
Contributor
Author
|
@stevenengler friendly ping - it'd be nice if I could get this merged today before I leaving town. I also have a couple small follow-ups to make it VirtualAddressSpaceIndependent and to change it from a union to a Rust enum |
stevenengler
approved these changes
Mar 3, 2023
This changes the names to match what cbindgen wants to call these when we migrate this enum to Rust. (I tried instead adding cbindgen annotations to a Rust version of the enum, but it doesn't seem to work).
82154de to
533c6c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just moves the C definitions mostly as-is from C to Rust, which will allow us to further extend them - e.g. by applying the
VirtualAddressSpaceIndependentderive macro