Fix backwards timeout condition#2759
Conversation
|
I'm surprised this didn't cause any tests to fail. I suppose we need specifically a blocking syscall with a deadline with a condition that becomes true, but is falsified before the event runs... |
Yeah I think it depends on if the syscall handler believes the value of |
|
The tor benchmark networking results change slightly, but not significantly. The runtime and memory results do not change. https://github.com/shadow/benchmark-results/tree/master/tor/2023-02-22-T15-06-28 |
59fbb03 to
7bf4b5c
Compare
The timeout condition in the
SysCallConditionis backwards, causing the process to wake up before its timeout has expired. (And maybe not wake up at all when it does exceed the timeout?)(This doesn't fix our tor onion service stream timeout issue.)