Merged
Conversation
e006729 to
6987497
Compare
6987497 to
f76a31d
Compare
Closed
stevenengler
approved these changes
Feb 21, 2023
Since in the planned design we don't intend to use mutable references to Thread, I thought we could omit the RootedRefCell wrapper here. We *could*, but without it we need to make Thread itself Sync, which means that for interior mutability we end up needing to use e.g. RootedCell instead of just Cell, and RootedRefCell instead of just RefCell. That in turn requires callers of most of Thread's methods to provide a Root. I think it'll be simpler (and maybe more performant) to just wrap the Thread itself in RootedRefCell, in which case Thread only needs to be Send, but doesn't need to be Sync.
6f5da73 to
e727c74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.