Rooted*: make public APIs inline#2750
Merged
sporksmith merged 1 commit intoshadow:mainfrom Feb 15, 2023
Merged
Conversation
Contributor
Author
|
Started a larger tor benchmark, mostly out of curiosity. I'm fairly confident this should be performance-neutral at worst. https://github.com/shadow/benchmark/actions/runs/4176543974 |
stevenengler
approved these changes
Feb 15, 2023
By default, Rust doesn't inline calls across crate boundaries. Since these functions are called frequently, and from across a crate boundary, we probably want them to be inline. We force this by marking them `#[inline]`, which is also done in the The analagous functions in `std`. A quick local benchmark using the tor minimal test shows there might be a measurable improvement here, though it's inconclusive since the confidence intervals overlap substantially: Before: ``` Benchmark 1: ./setup test --extra tor-minimal Time (mean ± σ): 17.424 s ± 0.455 s [User: 18.446 s, System: 6.024 s] Range (min … max): 16.818 s … 18.123 s 10 runs ``` After: ``` Benchmark 1: ./setup test --extra tor-minimal Time (mean ± σ): 17.119 s ± 0.482 s [User: 18.211 s, System: 5.993 s] Range (min … max): 16.534 s … 18.020 s 10 runs ```
a754e3f to
90143ec
Compare
Contributor
Author
|
The benchmark runner's tor benchmark looks neutral. Oh well, merging anyway, if nothing else so it doesn't come up again :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, Rust doesn't inline calls across crate boundaries. Since these functions are small, called frequently, and from across a crate boundary, we probably want them to be inline. We force this by marking them
#[inline], which is also done in the analogous functions instd.A quick local benchmark using the tor minimal test shows there might be a measurable improvement here, though it's inconclusive since the confidence intervals overlap substantially:
Before:
After: