Set shim's stdout/stderr to the shim log file#2725
Merged
stevenengler merged 1 commit intoshadow:mainfrom Feb 7, 2023
Merged
Conversation
sporksmith
approved these changes
Feb 7, 2023
Contributor
sporksmith
left a comment
There was a problem hiding this comment.
It overlaps a bit, but that's ok
Shadow now uses an fd passed through fork/exec for the shim log rather than passing a filename using `SHADOW_LOG_FILE`, and also uses this fd for stdout and stderr. If the shim writes to stdout/stderr (or the plugin disables interposition and writes to stdout/stderr), it should be written to the shim log rather than to shadow's stdout/stderr (which may be the terminal or some other file).
764c6fb to
0257da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow now uses an fd passed through fork/exec for the shim log rather than passing a filename using
SHADOW_LOG_FILE, and also uses this fd for stdout and stderr.If the shim writes to stdout/stderr (or the plugin disables interposition and writes to stdout/stderr), it should be written to the shim log rather than to shadow's stdout/stderr (which may be the terminal or some other file).
@sporksmith If this overlaps with your
Threadmigration let me know and I'll hold off on merging.