CI: remove debug builds from the primary test matrix#2724
Merged
sporksmith merged 1 commit intoshadow:mainfrom Feb 7, 2023
Merged
CI: remove debug builds from the primary test matrix#2724sporksmith merged 1 commit intoshadow:mainfrom
sporksmith merged 1 commit intoshadow:mainfrom
Conversation
Contributor
Author
|
@robgjansen This will need some of the debug builds removed from the required tests to be able to merge. I also modified the clang debug build. So to merge this as-is, the set of "shadow" tests we'd want to require now is: |
991a4a6 to
87eabc0
Compare
robgjansen
approved these changes
Feb 7, 2023
Testing both debug and release builds for every configuration is overkill. Testing a debug build for each compiler should be sufficient to catch debug-only bugs; e.g. a debug assertion that fails. Note that the same is not true of release builds - bugs arising from unsound/undefined behavior may only trigger on some platforms.
87eabc0 to
b7b74db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing both debug and release builds for every configuration is overkill. Testing a debug build for each compiler should be sufficient to catch most debug-only bugs; e.g. a debug assertion that fails.
Note that the same is not true of release builds - bugs arising from unsound/undefined behavior may only trigger on some platforms.