Skip to content

Don't run workflows on merge to main#2722

Merged
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:no-run-on-main
Feb 6, 2023
Merged

Don't run workflows on merge to main#2722
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:no-run-on-main

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

We don't need to run our CI on commits to main since main is already a protected branch that only allows merging from a PR that is up to date with main and has already passed the CI.

@github-actions github-actions bot added the Component: Testing Unit and integration tests and frameworks label Feb 6, 2023
@sporksmith sporksmith added this to the Code health and maintenance milestone Feb 6, 2023
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want to remove the badge from:

[![Shadow Tests](https://github.com/shadow/shadow/actions/workflows/run_tests_incremental.yml/badge.svg?branch=main&event=push)](https://github.com/shadow/shadow/actions/workflows/run_tests_incremental.yml?query=branch:main+event:push)

@github-actions github-actions bot added the Component: Documentation In-repository documentation, under docs/ label Feb 6, 2023
@sporksmith sporksmith enabled auto-merge February 6, 2023 16:19
We don't need to run our CI on commits to main since main is already a
protected branch that only allows merging from a PR that is up to date
with main and has already passed the CI.
This would become out of date since we're not running these tests
anymore.
@sporksmith sporksmith merged commit f1b2557 into shadow:main Feb 6, 2023
@sporksmith sporksmith deleted the no-run-on-main branch February 6, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants