Skip to content

Remove unused C utility code#2721

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:remove-unused-c-code
Feb 6, 2023
Merged

Remove unused C utility code#2721
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:remove-unused-c-code

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

No description provided.

@stevenengler stevenengler self-assigned this Feb 3, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Feb 3, 2023
@stevenengler stevenengler changed the title Remove unused C util code Remove unused C utility code Feb 3, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2023

Codecov Report

Base: 67.03% // Head: 67.95% // Increases project coverage by +0.92% 🎉

Coverage data is based on head (242694e) compared to base (6064cc8).
Patch has no changes to coverable lines.

❗ Current head 242694e differs from pull request most recent head 8733183. Consider uploading reports for the commit 8733183 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2721      +/-   ##
==========================================
+ Coverage   67.03%   67.95%   +0.92%     
==========================================
  Files         203      203              
  Lines       30513    30513              
  Branches     5970     5970              
==========================================
+ Hits        20454    20735     +281     
+ Misses       5375     5075     -300     
- Partials     4684     4703      +19     
Flag Coverage Δ
tests 67.95% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/shmem/src/scmutex.rs 87.05% <0.00%> (-2.36%) ⬇️
src/main/host/descriptor/socket/inet/mod.rs 42.51% <0.00%> (-0.79%) ⬇️
...c/main/utility/synchronization/count_down_latch.rs 85.10% <0.00%> (-0.54%) ⬇️
src/main/utility/byte_queue.rs 56.01% <0.00%> (ø)
src/main/core/manager.rs 63.63% <0.00%> (+0.44%) ⬆️
src/main/core/support/units.rs 56.36% <0.00%> (+0.51%) ⬆️
src/lib/shadow-shim-helper-rs/src/signals.rs 72.28% <0.00%> (+0.60%) ⬆️
src/main/host/descriptor/mod.rs 67.88% <0.00%> (+0.81%) ⬆️
src/main/host/syscall/handler/socket.rs 67.32% <0.00%> (+1.10%) ⬆️
src/main/host/process.rs 79.49% <0.00%> (+1.56%) ⬆️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler force-pushed the remove-unused-c-code branch 2 times, most recently from dce8434 to 242694e Compare February 6, 2023 16:20
@stevenengler stevenengler merged commit b76d8ea into shadow:main Feb 6, 2023
@stevenengler stevenengler deleted the remove-unused-c-code branch February 6, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants