Support rust InetSockets in the network interface#2713
Merged
stevenengler merged 3 commits intoshadow:mainfrom Feb 2, 2023
Merged
Support rust InetSockets in the network interface#2713stevenengler merged 3 commits intoshadow:mainfrom
InetSockets in the network interface#2713stevenengler merged 3 commits intoshadow:mainfrom
Conversation
d28d837 to
7577a52
Compare
Codecov ReportBase: 67.82% // Head: 68.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2713 +/- ##
==========================================
+ Coverage 67.82% 68.07% +0.25%
==========================================
Files 203 203
Lines 30509 30513 +4
Branches 5970 5970
==========================================
+ Hits 20693 20772 +79
+ Misses 5117 5038 -79
- Partials 4699 4703 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cce0916 to
5490787
Compare
sporksmith
approved these changes
Feb 2, 2023
`CompatSocket`s that point to rust `InetSocket`s might store different addresses that point to the same underlying socket object. So if two tagged pointers are different, it doesn't mean that they point to different sockets.
This reverts commit 8e000f4.
5490787 to
5ef8005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
remove_all_socketsmethod to the network interface — since sockets might access the global host when they're freed/dropped, we should free/drop the sockets while the global host is still set (so before we drop the host)InetSocketrather than as aLegacySocketThe benchmark results change slightly for some reason, but they're very similar in both the tgen and tor benchmarks.
tgen
tor