Push local packets directly to netif, stop using events#2711
Push local packets directly to netif, stop using events#2711robgjansen merged 1 commit intoshadow:mainfrom
Conversation
Codecov ReportBase: 68.07% // Head: 67.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2711 +/- ##
==========================================
- Coverage 68.07% 67.85% -0.22%
==========================================
Files 203 203
Lines 30515 30509 -6
Branches 5971 5970 -1
==========================================
- Hits 20773 20703 -70
- Misses 5032 5107 +75
+ Partials 4710 4699 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
TGen results are as expected. We don't see an performance improvement since the TGen benchmark is not sending packets over localhost, however the Tor benchmark does send localhost packets so we may see an improvement when that is next run. |
Local packets were previously "sent" to the netif by scheduling an event. This commit changes this behavior to instead just directly push local packets to the destination netif. This results in fewer events (it saves 1 event for every local packet) and should thus be more performant. It does change the order of operations a bit, so we expect non-deterministic results across this commit.
d837230 to
7d53ee5
Compare
Local packets were previously "sent" to the netif by scheduling an event. This commit changes this behavior to instead just directly push local packets to the destination netif. This results in fewer events (it saves 1 event for every local packet) and should thus be more performant. It does change the order of operations a bit, so we expect non-deterministic results across this commit.