Skip to content

Relay design improvements#2706

Merged
robgjansen merged 3 commits intoshadow:mainfrom
robgjansen:relay-design
Jan 31, 2023
Merged

Relay design improvements#2706
robgjansen merged 3 commits intoshadow:mainfrom
robgjansen:relay-design

Conversation

@robgjansen
Copy link
Copy Markdown
Member

@robgjansen robgjansen commented Jan 29, 2023

No description provided.

@robgjansen robgjansen added Type: Enhancement New functionality or improved design Component: Main Composing the core Shadow executable labels Jan 29, 2023
@robgjansen robgjansen self-assigned this Jan 29, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2023 •
edited
Loading

Codecov Report

Base: 68.11% // Head: 68.12% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (3e6a03c) compared to base (668fd1a).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head 3e6a03c differs from pull request most recent head 3065cdf. Consider uploading reports for the commit 3065cdf to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
+ Coverage   68.11%   68.12%   +0.01%     
==========================================
  Files         203      203              
  Lines       30466    30466              
  Branches     5959     5959              
==========================================
+ Hits        20751    20755       +4     
+ Misses       5011     5008       -3     
+ Partials     4704     4703       -1
Flag Coverage Δ
tests 68.12% <90.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/network/relay/mod.rs 84.33% <90.90%> (ø)
src/main/core/worker.rs 77.38% <0.00%> (-4.64%) ⬇️
src/main/core/logger/shadow_logger.rs 69.61% <0.00%> (-2.77%) ⬇️
src/main/host/syscall/handler/socket.rs 67.10% <0.00%> (-0.67%) ⬇️
src/test/signal/test_signals.rs 84.28% <0.00%> (-0.36%) ⬇️
src/main/host/process.rs 78.45% <0.00%> (-0.32%) ⬇️
src/main/core/manager.rs 64.52% <0.00%> (-0.23%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 71.40% <0.00%> (+0.20%) ⬆️
src/main/host/syscall/handler/fcntl.rs 60.56% <0.00%> (+1.40%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen
Copy link
Copy Markdown
Member Author

robgjansen commented Jan 31, 2023

TGen benchmark results:
https://github.com/shadow/benchmark-results/tree/master/tgen/2023-01-30-T21-14-49

@robgjansen robgjansen merged commit 9a66b2f into shadow:main Jan 31, 2023
@robgjansen robgjansen deleted the relay-design branch January 31, 2023 00:45
@stevenengler
Copy link
Copy Markdown
Contributor

stevenengler commented Jan 31, 2023 •
edited
Loading

There does seem to have been a change to the retransmission overhead, but I don't see an obvious reason why this would be the case, so I think it's fine.

1675126861_grim

The simulation may have also become a little slower.

1675127261_grim

@stevenengler
Copy link
Copy Markdown
Contributor

stevenengler commented Jan 31, 2023

Actually the previous benchmark run (the weekly) was run before #2690 was merged, so maybe that PR explains the difference shown in this graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@robgjansen robgjansen

Labels

Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Improve modularity of router object

Development

Successfully merging this pull request may close these issues.

2 participants

@robgjansen @stevenengler