Skip to content

Delete unused process_insertThread#2701

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:delete-insert-thread
Jan 26, 2023
Merged

Delete unused process_insertThread#2701
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:delete-insert-thread

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Jan 26, 2023

No description provided.

@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 26, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2023 •
edited
Loading

Codecov Report

Base: 68.13% // Head: 68.07% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (a00a63e) compared to base (abeb80e).
Patch coverage: 72.72% of modified lines in pull request are covered.

❗ Current head a00a63e differs from pull request most recent head a7aac54. Consider uploading reports for the commit a7aac54 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   68.13%   68.07%   -0.07%     
==========================================
  Files         202      202              
  Lines       30407    30414       +7     
  Branches     5938     5949      +11     
==========================================
- Hits        20719    20703      -16     
- Misses       4996     5005       +9     
- Partials     4692     4706      +14
Flag Coverage Δ
tests 68.07% <72.72%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/process.rs 78.81% <ø> (+0.81%) ⬆️
src/main/host/memory_manager/memory_mapper.rs 71.40% <72.72%> (-0.24%) ⬇️
src/main/host/descriptor/descriptor_table.rs 63.71% <0.00%> (-9.74%) ⬇️
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-4.55%) ⬇️
src/lib/shmem/src/scmutex.rs 87.05% <0.00%> (-2.36%) ⬇️
src/main/core/main.rs 39.13% <0.00%> (-1.87%) ⬇️
src/main/host/syscall/handler/fcntl.rs 59.15% <0.00%> (-1.41%) ⬇️
src/main/host/descriptor/socket/inet/mod.rs 27.34% <0.00%> (-0.79%) ⬇️
src/main/host/syscall/handler/socket.rs 66.66% <0.00%> (-0.45%) ⬇️
src/main/core/sim_config.rs 55.02% <0.00%> (-0.44%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sporksmith sporksmith force-pushed the delete-insert-thread branch from a00a63e to a7aac54 Compare January 26, 2023 22:08
@sporksmith sporksmith enabled auto-merge (squash) January 26, 2023 22:09
@sporksmith sporksmith merged commit 9b668e1 into shadow:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@sporksmith @stevenengler