Skip to content

process_continue: take thread id instead of thread*#2700

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:process_continue
Jan 26, 2023
Merged

process_continue: take thread id instead of thread*#2700
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:process_continue

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

Simplifies API and implementation

@sporksmith sporksmith enabled auto-merge (squash) January 26, 2023 21:35
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 26, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2023

Codecov Report

Base: 68.13% // Head: 67.70% // Decreases project coverage by -0.44% ⚠️

Coverage data is based on head (ec58f69) compared to base (abeb80e).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   68.13%   67.70%   -0.44%     
==========================================
  Files         202      202              
  Lines       30407    30424      +17     
  Branches     5938     5949      +11     
==========================================
- Hits        20719    20599     -120     
- Misses       4996     5147     +151     
+ Partials     4692     4678      -14     
Flag Coverage Δ
tests 67.70% <75.00%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/memory_manager/memory_mapper.rs 71.40% <72.72%> (-0.24%) ⬇️
src/main/host/process.rs 78.30% <100.00%> (+0.30%) ⬆️
src/main/host/syscall/handler/eventfd.rs 0.00% <0.00%> (-65.72%) ⬇️
src/main/host/descriptor/eventfd.rs 8.08% <0.00%> (-57.58%) ⬇️
src/main/host/syscall/handler/fcntl.rs 45.07% <0.00%> (-15.50%) ⬇️
src/main/host/descriptor/descriptor_table.rs 62.83% <0.00%> (-10.62%) ⬇️
src/main/host/syscall/handler/unistd.rs 65.10% <0.00%> (-5.11%) ⬇️
src/main/host/syscall/handler/ioctl.rs 52.94% <0.00%> (-2.95%) ⬇️
src/main/host/syscall/type_formatting.rs 74.78% <0.00%> (-2.61%) ⬇️
src/main/utility/shm_cleanup.rs 61.36% <0.00%> (-2.28%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sporksmith sporksmith merged commit aca58a8 into shadow:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants