MemoryManager: coalesce initial adjacent compatible regions#2699
Merged
sporksmith merged 2 commits intoshadow:mainfrom Jan 26, 2023
Merged
MemoryManager: coalesce initial adjacent compatible regions#2699sporksmith merged 2 commits intoshadow:mainfrom
sporksmith merged 2 commits intoshadow:mainfrom
Conversation
stevenengler
approved these changes
Jan 26, 2023
This is to work around an odd behavior in Linux kernel 6.1.6 on Fedora 37 - it sometimes reports two heap regions with identical properties. Rather than further-complicating the heap mapping code, it's probably better to just normalize the initial region map to collapse the heaps into a single region.
We get confusing behavior later if there are multiple heaps; better to bail out earlier. e.g. when debugging shadow#2686 it would have been clearer what was happening if we failed here and didn't try to keep running.
e2c6b5b to
5155d97
Compare
Codecov ReportBase: 68.06% // Head: 67.66% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
==========================================
- Coverage 68.06% 67.66% -0.41%
==========================================
Files 202 202
Lines 30407 30343 -64
Branches 5938 5932 -6
==========================================
- Hits 20698 20533 -165
- Misses 5012 5148 +136
+ Partials 4697 4662 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to work around an odd behavior in Linux kernel 6.1.6 on Fedora 37 - it sometimes reports two heap regions with identical properties.
Rather than further-complicating the heap mapping code, it's probably better to just normalize the initial region map to collapse the heaps into a single region.
Verified that this fixes the tor-minimal test in a Fedora 37 VM.
Fixes #2692