Close the LegacyFile when the last LegacyFileCounter is dropped#2698
Merged
stevenengler merged 2 commits intoshadow:mainfrom Jan 25, 2023
Merged
Close the LegacyFile when the last LegacyFileCounter is dropped#2698stevenengler merged 2 commits intoshadow:mainfrom
LegacyFile when the last LegacyFileCounter is dropped#2698stevenengler merged 2 commits intoshadow:mainfrom
Conversation
Codecov ReportBase: 68.15% // Head: 67.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2698 +/- ##
==========================================
- Coverage 68.15% 67.45% -0.70%
==========================================
Files 202 202
Lines 30378 30388 +10
Branches 5928 5930 +2
==========================================
- Hits 20703 20499 -204
- Misses 4986 5227 +241
+ Partials 4689 4662 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
LegacyFileCountermore closely matchOpenFile, so that if a descriptor is dropped, it may run the file's close method.See discussion in #2691 (comment).