Simplify the host's networking cleanup#2697
Merged
stevenengler merged 2 commits intoshadow:mainfrom Jan 25, 2023
Merged
Conversation
Codecov ReportBase: 68.09% // Head: 67.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2697 +/- ##
==========================================
- Coverage 68.09% 67.46% -0.63%
==========================================
Files 202 202
Lines 30388 30391 +3
Branches 5930 5933 +3
==========================================
- Hits 20693 20504 -189
- Misses 5001 5224 +223
+ Partials 4694 4663 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2348adc to
b280dba
Compare
robgjansen
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the host's
net_ns: RefCell<Option<NetworkNamespace>>tonet_ns: NetworkNamespaceby adding aNetworkNamespace::cleanupfunction that has to be run while the worker has an active host. The network namespace objects have also been wrapped in aRefCell. The network interface objects don't have any&mutmethods so thisRefCellisn't currently needed, but we'll likely want to give them&mutmethods in the future.@robgjansen This can be merged either before or after your changes, whichever makes it easier for your PR.