Skip to content

Add support for Fedora 37 in the CI#2687

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:fedora-37
Jan 23, 2023
Merged

Add support for Fedora 37 in the CI#2687
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:fedora-37

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jan 23, 2023

No description provided.

@stevenengler stevenengler self-assigned this Jan 23, 2023
@github-actions github-actions bot added Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks labels Jan 23, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2023 •
edited
Loading

Codecov Report

Base: 67.76% // Head: 67.75% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (7eff7c8) compared to base (8cb7e91).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2687      +/-   ##
==========================================
- Coverage   67.76%   67.75%   -0.02%     
==========================================
  Files         202      202              
  Lines       30326    30326              
  Branches     5921     5921              
==========================================
- Hits        20550    20546       -4     
- Misses       5109     5110       +1     
- Partials     4667     4670       +3
Flag Coverage Δ
tests 67.75% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-2.28%) ⬇️
src/main/host/syscall/handler/socket.rs 68.22% <0.00%> (-0.64%) ⬇️
src/main/host/descriptor/pipe.rs 84.37% <0.00%> (-0.63%) ⬇️
src/main/core/sim_config.rs 55.02% <0.00%> (-0.44%) ⬇️
src/main/host/host.rs 80.67% <0.00%> (-0.18%) ⬇️
src/lib/tsc/tsc_test.c 12.67% <0.00%> (ø)
src/main/host/process.rs 78.17% <0.00%> (+0.10%) ⬆️
src/main/host/memory_manager/memory_mapper.rs 71.63% <0.00%> (+0.20%) ⬆️
src/main/core/manager.rs 63.63% <0.00%> (+0.22%) ⬆️
...c/main/utility/synchronization/count_down_latch.rs 85.63% <0.00%> (+0.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler changed the title Add support for Fedora 37 Add support for Fedora 37 in the CI Jan 23, 2023
sporksmith
sporksmith reviewed Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and seems like we ought to do it since the other current supported versions are EOL, but probably worth running by @robgjansen since it's a long term maintenance "promise"

robgjansen
robgjansen approved these changes Jan 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, people do use Fedora so it's nice to test it.

@stevenengler stevenengler merged commit 34fe9d8 into shadow:main Jan 23, 2023
@stevenengler stevenengler deleted the fedora-37 branch January 23, 2023 23:29
@stevenengler stevenengler restored the fedora-37 branch January 23, 2023 23:29
@stevenengler stevenengler deleted the fedora-37 branch January 23, 2023 23:29
@stevenengler stevenengler restored the fedora-37 branch January 23, 2023 23:29
@stevenengler stevenengler deleted the fedora-37 branch January 23, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith left review comments

@robgjansen robgjansen robgjansen approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

3 participants

@stevenengler @sporksmith @robgjansen